This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Fix/72 #75
Merged
Fix/72 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -365,9 +365,16 @@ SearchParameters.prototype = { | |||
| * @return {SearchParameters} | |||
| */ | |||
| addFacetRefinement : function addFacetRefinement( facet, value ) { | |||
| if( this.isRefined( facet, value ) ) { | |||
| return this; | |||
There was a problem hiding this comment.
Shouldn't it return a this.mutateMe(noop) instead ? So the return of addFacetRefinement is consistenly a new object ?
There was a problem hiding this comment.
In the case isRefined( facet, value ) returns true, it would mean that there would be no changes, so might as well avoid creating a new instance (there are thousands of case we create useless new objects, true :D, it's just continuous improvement here)
|
Except that, LGTM. 👍 |
|
👍 LGTM |
| if( idx > -1 ) { | ||
| m.facetsRefinements[ facet ].splice( idx, 1 ); | ||
| if( m.facetsRefinements[ facet ].length === 0 ) { | ||
| delete m.facetsRefinements[ facet ]; |
There was a problem hiding this comment.
why do we need to delete the array?
There was a problem hiding this comment.
actually we remove the key from the object so when iterating with a for in we don't need to check for the content.
|
LGTM |
|
Thanks for the comments :) Merging! |
bobylito
added a commit
that referenced
this pull request
May 13, 2015
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@redox @pixelastic @jerskouille @maxiloc @vvo Review please? :)